pcf8591: add ADC only implementation for I2C ADC/DAC #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sago35
requested changes
Jun 30, 2024
|
Thanks for the quick feedback @sago35 changes made to this PR, please take a look. |
sago35
reviewed
Jun 30, 2024
Signed-off-by: deadprogram <ron@hybridgroup.com>
|
Thanks for the proofreading @sago35 changes made and pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an ADC only implementation for the pcf8591 I2C ADC/DAC.
A future PR can add the DAC feature.