compiler: remove support for memory references in AsmFull #2790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means fewer instances of arm.AsmFull, which I'd like to remove eventually if possible.
Memory references (`*m` in LLVM IR inline assembly) need a pointer type starting in LLVM 14. This is a bit inconvenient and requires a new API in the go-llvm package. Instead of doing that, I'd like to remove support for memory references from AsmFull (and possibly AsmFull entirely if possible: it's hard to use correctly). This breaks tinygo.org/x/drivers/ws2812 for AVR, ARM, and RISC-V which need to be updated. Probably using CGo.
|
Tested with tinygo-org/drivers#401 which was merged, and worked as expected. Is there something else I am missing here or can we merge now? |
deadprogram
approved these changes
Apr 21, 2022
|
Merging since it is working for me. |
aykevl
added a commit
to tinygo-org/tinygo-site
that referenced
this pull request
Apr 21, 2022
For details, see: * tinygo-org/drivers#401 * tinygo-org/tinygo#2790 Essentially, this updates the inline assembly to the current best practice.
I doubt inline assembly is used in many places. But the docs need to be updated, for which I've created a PR: tinygo-org/tinygo-site#258 |
deadprogram
pushed a commit
to tinygo-org/tinygo-site
that referenced
this pull request
Apr 22, 2022
For details, see: * tinygo-org/drivers#401 * tinygo-org/tinygo#2790 Essentially, this updates the inline assembly to the current best practice.
deadprogram
pushed a commit
to tinygo-org/tinygo-site
that referenced
this pull request
Apr 29, 2022
For details, see: * tinygo-org/drivers#401 * tinygo-org/tinygo#2790 Essentially, this updates the inline assembly to the current best practice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Memory references (
*min LLVM IR inline assembly) need a pointer type starting in LLVM 14. This is a bit inconvenient and requires a new API in the go-llvm package.Instead of doing that, I'd like to remove support for memory references from AsmFull (and possibly AsmFull entirely if possible: it's hard to use correctly).
This breaks tinygo.org/x/drivers/ws2812 for AVR, ARM, and RISC-V which need to be updated. Probably using CGo.