Binaryen116 #3958
Merged
Binaryen116 #3958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@deadprogram this is the new PR, which updates to binaryen 116 |
Ensure latest version of binaryen is used by GH actions on linux. Required to fix issue#3881 Signed-off-by: Flavio Castelli <fcastelli@suse.com>
Signed-off-by: Flavio Castelli <fcastelli@suse.com>
Signed-off-by: Flavio Castelli <fcastelli@suse.com>
|
Thank you for the update @flavio I am going to squash/merge now. |
aykevl
reviewed
Oct 16, 2023
| command: git submodule update --init | ||
| command: git submodule update --init --recursive |
There was a problem hiding this comment.
Just wondering, is this --recursive a new requirement? (Because it also pulls another submodule that we don't actually need).
There was a problem hiding this comment.
Without that, the code would not compile because of some missing dependency
There was a problem hiding this comment.
I think I found it. The extra dependency will be disabled here: #4154
crypto-smoke
pushed a commit
to meshnet-gophers/tinygo
that referenced
this pull request
Feb 14, 2024
dependencies: update binaryen submodule to version 116 Signed-off-by: Flavio Castelli <fcastelli@suse.com> Co-authored-by: DarkByteBen <ben@darkbytelabs.com>
aykevl
added a commit
that referenced
this pull request
Feb 26, 2024
It's not generally needed. It was added in #3958 to fix an issue with binaryen that has since been fixed in a different way, so we don't need the googletest dependency anymore.
aykevl
added a commit
that referenced
this pull request
Mar 12, 2024
It's not generally needed. It was added in #3958 to fix an issue with binaryen that has since been fixed in a different way, so we don't need the googletest dependency anymore.
deadprogram
pushed a commit
that referenced
this pull request
Mar 24, 2024
It's not generally needed. It was added in #3958 to fix an issue with binaryen that has since been fixed in a different way, so we don't need the googletest dependency anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #3882 which seems to be no longer active.
I've run into issue #3881 too, this is why I would like to see this fix merged.
I've rebased the original PR against latest
devbranch, and applied the requests from this comment.Moreover, I've updated to latest release of binaryen v116, instead of v114 of the original PR
I've searched for other places inside of the GitHub actions where the binaryen code is checkout out, but this seems to be specific to Linux. On Mac/Windows the binaryen binaries are installed via package managers (brew and scoop).