Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tinygo: add relative and absolute --dir options to wasmtime args #4431

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

ydnar
Copy link
Contributor

@ydnar ydnar commented Aug 22, 2024

This is a second stab at fixing the wasip1 and wasip2 --dir args to wasmtime.

@dgryski
Copy link
Member

dgryski commented Aug 26, 2024

I think there is some code in the waisp1 or wasip2 branch that detects "something" (will need to double check) based on the first or last --dir option provided. Are we breaking anything else by effectively having two names for each directory in the module path here?

@ydnar ydnar marked this pull request as ready for review August 26, 2024 19:41
@ydnar
Copy link
Contributor Author

ydnar commented Aug 26, 2024

I think there is some code in the waisp1 or wasip2 branch that detects "something" (will need to double check) based on the first or last --dir option provided. Are we breaking anything else by effectively having two names for each directory in the module path here?

It worked for the tests I ran. Did you discover anything?

@dgryski
Copy link
Member

dgryski commented Aug 26, 2024

No, I was just wondering because I know I had issues with argument ordering. I didn't see any failures, but I can run my larger test corpus and see what falls out.

@aykevl
Copy link
Member

aykevl commented Aug 27, 2024

@ydnar did you get any further with this PR?
You could try running the test locally (make test GOTESTPKGS=. GOTESTFLAGS="-v -run=Build"), maybe it'll give some more information as to what goes wrong?

@ydnar
Copy link
Contributor Author

ydnar commented Aug 27, 2024

I haven't. I'll try that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants