Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiler: fix passing weirdly-padded structs to new goroutines #4449

Merged
merged 2 commits into from
Sep 5, 2024
Merged

compiler: fix passing weirdly-padded structs to new goroutines #4449

merged 2 commits into from
Sep 5, 2024

Commits on Aug 31, 2024

  1. compiler: move some code around to make the next bugfix easier 

    This just makes the next fix easier to read.
    @aykevl
    aykevl committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    85b64fd View commit details
    Browse the repository at this point in the history

  2. compiler: fix passing weirdly-padded structs to new goroutines 

    The values were stored in the passed object as the values itself (not
expanded like is common in the calling convention), and read back after
assuming they were expanded. This often works for simple parameters
(int, pointer, etc), but not for more complex parameters. Especially
when there's padding.

Found this while working on `//go:wasmexport`.
    @aykevl
    aykevl committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    10b5f4c View commit details
    Browse the repository at this point in the history