Ensure build output directory is created #4707
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`tinygo build -o /path/to/out .` expected `/path/to/out` to already exist, which is different behaviour to `go build`. This change ensures tinygo creates any directories needed to be able to build to the specified output dir.
jphastings
force-pushed
the
4687-create-output-dir
branch
from
b7044ab to
70387ac
Compare
jphastings
commented
Jan 18, 2025
| @@ -604,6 +604,11 @@ func Build(pkgName, outpath, tmpdir string, config *compileopts.Config) (BuildRe | |||
| }, | |||
| } | |||
|
|
|||
| // Create the output directory, if needed | |||
| if err := os.MkdirAll(filepath.Dir(outpath), 0777); err != nil { | |||
There was a problem hiding this comment.
I picked 777 to match the files' 666 permissions later in this code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tinygo build -o /path/to/out .expected/path/to/outto already exist, which is different behaviour togo build. This change ensures tinygo creates any directories needed to be able to build to the specified output dir.I wasn't certain how to effectively test this change within this repo (this is my first TinyGo contribution), any advice would be welcome!
fixes #4687