-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
omitzero implementation #334
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
klauspost
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mx-psi
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Jul 9, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/tinylib/msgp](https://github.com/tinylib/msgp) | `v1.1.9` -> `v1.2.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2ftinylib%2fmsgp/v1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2ftinylib%2fmsgp/v1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2ftinylib%2fmsgp/v1.1.9/v1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2ftinylib%2fmsgp/v1.1.9/v1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>tinylib/msgp (github.com/tinylib/msgp)</summary> ### [`v1.2.0`](https://github.com/tinylib/msgp/releases/tag/v1.2.0) [Compare Source](https://github.com/tinylib/msgp/compare/v1.1.9...v1.2.0) ##### What's Changed - omitzero implementation by [@​bradleypeabody](https://github.com/bradleypeabody) in [tinylib/msgp#334 - `replace` directive by [@​infastin](https://github.com/infastin) in [tinylib/msgp#346 - Support custom struct tags by [@​very-amused](https://github.com/very-amused) in [tinylib/msgp#347 - Add map\[string]struct{} support by [@​klauspost](https://github.com/klauspost) in [tinylib/msgp#339 - Add `any` support by [@​VirrageS](https://github.com/VirrageS) in [tinylib/msgp#350 - support for `any` maps in msgp.AppendIntf like in (\*Writer).WriteIntf by [@​eliottness](https://github.com/eliottness) in [tinylib/msgp#340 - allownil: Allocate 0 length slices by [@​klauspost](https://github.com/klauspost) in [tinylib/msgp#336 - Fix ignored tag directives on unnamed fields by [@​klauspost](https://github.com/klauspost) in [tinylib/msgp#352 - Added `time.Duration` case to AppendIntf by [@​RiaanLaubscher](https://github.com/RiaanLaubscher) in [tinylib/msgp#353 - Bounds checks elimination by [@​mhr3](https://github.com/mhr3) in [tinylib/msgp#348 - test AppendIntf against ReadIntfBytes by [@​eliottness](https://github.com/eliottness) in [tinylib/msgp#341 - Support illumos. by [@​jperkin](https://github.com/jperkin) in [tinylib/msgp#343 ##### New Contributors - [@​eliottness](https://github.com/eliottness) made their first contribution in [tinylib/msgp#340 - [@​jperkin](https://github.com/jperkin) made their first contribution in [tinylib/msgp#343 - [@​very-amused](https://github.com/very-amused) made their first contribution in [tinylib/msgp#347 - [@​RiaanLaubscher](https://github.com/RiaanLaubscher) made their first contribution in [tinylib/msgp#353 - [@​infastin](https://github.com/infastin) made their first contribution in [tinylib/msgp#346 **Full Changelog**: tinylib/msgp@v1.1.9...v1.2.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jul 11, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/tinylib/msgp](https://github.com/tinylib/msgp) | `v1.1.9` -> `v1.2.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2ftinylib%2fmsgp/v1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2ftinylib%2fmsgp/v1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2ftinylib%2fmsgp/v1.1.9/v1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2ftinylib%2fmsgp/v1.1.9/v1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>tinylib/msgp (github.com/tinylib/msgp)</summary> ### [`v1.2.0`](https://github.com/tinylib/msgp/releases/tag/v1.2.0) [Compare Source](https://github.com/tinylib/msgp/compare/v1.1.9...v1.2.0) ##### What's Changed - omitzero implementation by [@&open-telemetry#8203;bradleypeabody](https://github.com/bradleypeabody) in [tinylib/msgp#334 - `replace` directive by [@&open-telemetry#8203;infastin](https://github.com/infastin) in [tinylib/msgp#346 - Support custom struct tags by [@&open-telemetry#8203;very-amused](https://github.com/very-amused) in [tinylib/msgp#347 - Add map\[string]struct{} support by [@&open-telemetry#8203;klauspost](https://github.com/klauspost) in [tinylib/msgp#339 - Add `any` support by [@&open-telemetry#8203;VirrageS](https://github.com/VirrageS) in [tinylib/msgp#350 - support for `any` maps in msgp.AppendIntf like in (\*Writer).WriteIntf by [@&open-telemetry#8203;eliottness](https://github.com/eliottness) in [tinylib/msgp#340 - allownil: Allocate 0 length slices by [@&open-telemetry#8203;klauspost](https://github.com/klauspost) in [tinylib/msgp#336 - Fix ignored tag directives on unnamed fields by [@&open-telemetry#8203;klauspost](https://github.com/klauspost) in [tinylib/msgp#352 - Added `time.Duration` case to AppendIntf by [@&open-telemetry#8203;RiaanLaubscher](https://github.com/RiaanLaubscher) in [tinylib/msgp#353 - Bounds checks elimination by [@&open-telemetry#8203;mhr3](https://github.com/mhr3) in [tinylib/msgp#348 - test AppendIntf against ReadIntfBytes by [@&open-telemetry#8203;eliottness](https://github.com/eliottness) in [tinylib/msgp#341 - Support illumos. by [@&open-telemetry#8203;jperkin](https://github.com/jperkin) in [tinylib/msgp#343 ##### New Contributors - [@&open-telemetry#8203;eliottness](https://github.com/eliottness) made their first contribution in [tinylib/msgp#340 - [@&open-telemetry#8203;jperkin](https://github.com/jperkin) made their first contribution in [tinylib/msgp#343 - [@&open-telemetry#8203;very-amused](https://github.com/very-amused) made their first contribution in [tinylib/msgp#347 - [@&open-telemetry#8203;RiaanLaubscher](https://github.com/RiaanLaubscher) made their first contribution in [tinylib/msgp#353 - [@&open-telemetry#8203;infastin](https://github.com/infastin) made their first contribution in [tinylib/msgp#346 **Full Changelog**: tinylib/msgp@v1.1.9...v1.2.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a PR for
omitzero
support, following the discussion at #326.Highlights are:
omitzero
is now separate fromomitempty
, the former emits a function call to IsZero(), and the latter checks against the Go zero value. They both use the same bitmask and other related logic, only the actual check to determine if the field should be omitted is affected. I also adjusted a few comments to reflect these changes, nothing major.omitempty
feature and not by theomitzero
feature is unfortunate, but I don't think a deal-breaker. Probably better to just leave it and keep it simple, rather than trying to refactor the name of IfZeroExpr to fix this minor naming oddity.Let me know if anything else is needed for this, but hopefully that addresses all the concerns.