Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Utilize philhofer/fwd#32 to peek bytes
Eliminate bounds checks, mostly on reading sizes, but also integers.
Apologies for the noisy benchmark.
BenchmarkReadNilByte
andBenchmarkReadFloat64Byte
does not touch new code, so it seems to be "micro-bench-itis", where random deltas show up. Bench takes ~30m to run for whatever reason.The compiler is not clever enough to track back to
l := len(b)
, so it inserts a bounds check. Alsolen(b) < 3
andbig.Uint16(b[1:])
causes a bounds check. So we rewrite those to avoid it.This should cover the lowest hanging fruits.