Implementing an Image Classification App in One Minute for TinyMS 0.3.1 #140

xinwenh · 2022-01-25T17:03:05Z

What type of PR is this?

/kind enhancement

What does this PR do / why do we need it:

This PR updates tinyms0 3.1 realize the document of "realizing one graphic classification application in one minute" and publish it (Chinese version and English version) on the official document website.

Which issue(s) this PR fixes:

Special notes for your reviewers:

hellowaywewe · 2022-01-26T01:21:12Z

@xinwenh please update your branch to ensure that the latest content of your branch is consistent with the main branch.

lwdragon · 2022-01-26T01:26:40Z

docs/zh_CN/source/quickstart/quickstart_in_one_minute.ipynb

   "metadata": {},
   "source": [
    "#### 6.2 List servables\n",
    "\n",
-    "使用`list_servables`函数检查当前后端的serving模型"
+    "使用`list_servables`函数检查当前后端的serving模型,如果这边报错，在root下download_dataset('mnist', '/root'),然后从头运行一遍。"


Hi,@xinwenh .This path /root is inconsistent with the previous one.

ok i will perfect it

xinwenh · 2022-01-26T01:32:14Z

docs/zh_CN/source/quickstart/quickstart_in_one_minute.ipynb

   "metadata": {},
   "source": [
    "#### 6.2 List servables\n",
    "\n",
-    "使用`list_servables`函数检查当前后端的serving模型"
+    "使用`list_servables`函数检查当前后端的serving模型,如果这边报错，在root下download_dataset('mnist', '/root'),然后从头运行一遍。"


ok i will perfect it

docs/zh_CN/source/quickstart/quickstart_in_one_minute.ipynb

hellowaywewe · 2022-01-26T01:34:14Z

docs/en/source/quickstart/quickstart_in_one_minute.ipynb

+   "id": "6d74fafa",
+   "metadata": {},
+   "source": [
+    "Next, we need to go to the menu bar and click `File`=>`new Notebook` to create a new Jupyter file, and then continue to complete the next operation"


This is not the latest thing I asked you to fix yesterday.

lwdragon · 2022-01-26T02:13:48Z

Hi,@xinwenh. I found that the picture path of your output in Module 6 inference is inconsistent with that of your code. You'd better update the output.

hellowaywewe · 2022-01-26T13:15:51Z

docs/zh_CN/source/quickstart/quickstart_in_one_minute.ipynb

   "metadata": {},
   "source": [
    "### 2. 下载数据集\n",
    "\n",
-    "如果根目录下没有创建`mnist`文件夹则MNIST数据集会被自动下载并存放到根目录，如果`mnist`文件夹已经存在于根目录 ，则此步操作会被跳过"
+    "如果根目录下没有创建`mnist`文件夹则MNIST数据集会被自动下载并存放到根目录，如果`mnist`文件夹已经存在于根目录 ，则此步操作会被跳过。"


/home/jovyan is the user home directory not the root directory.

hellowaywewe · 2022-01-26T13:21:46Z

docs/en/source/quickstart/quickstart_in_one_minute.ipynb

+   "id": "6d74fafa",
+   "metadata": {},
+   "source": [
+    "After the server is started. we need to go to the menu bar and click `File`=>`new Notebook` to create a new jupyter file, and then continue to complete the operation of the client."


The started word should be followed by a comma.

hellowaywewe · 2022-01-26T13:25:37Z

docs/en/source/quickstart/quickstart_in_one_minute.ipynb

@@ -88,7 +82,7 @@
  },
  {
   "cell_type": "markdown",
-   "id": "guided-activation",
+   "id": "11fd53a1",
   "metadata": {},
   "source": [
    "### 2. Download dataset\n",


/home/jovyan is the user home directory not the root directory.

hellowaywewe · 2022-01-26T13:27:42Z

docs/en/source/quickstart/quickstart_in_one_minute.ipynb

   ]
  },
  {
   "cell_type": "markdown",
-   "id": "greenhouse-dutch",
+   "id": "a0ecea1c",
   "metadata": {},
   "source": [
    "### 6. Make predictions\n",


/home/jovyan is the user home directory not the root directory.

lwdragon · 2022-01-26T13:55:25Z

docs/en/source/quickstart/quickstart_in_one_minute.ipynb

    "\n",
-    "This tutorial consists of six parts, `constructing the model`, `downloading dataset`, `training`, `define servable json`, `starting server` and `making predictions` in which the server will be run in a sub process."
+    "This tutorial consists of six parts, `constructing the model`, `downloading dataset`, `training, define servable json`, `starting server` and `making predictions` in which the server will be run in a sub process."


Hi, @xinwenh.training, define servable json should be training, define servable json.You accidentally removed a backtick. I suggest you look at your own formatting issues on the pr interface after the push, instead of asking us to find these formatting issues

lwdragon · 2022-01-26T14:08:22Z

docs/zh_CN/source/quickstart/quickstart_in_one_minute.ipynb

@@ -30,7 +24,7 @@
  {


介绍
TinyMS是一个高级API，目的是让新手用户能够更加轻松地上手深度学习。TinyMS可以有效地减少用户在构建、训练、验证和推理一个模型过程中的操作次数。TinyMS也提供了教程和文档帮助开发者更好的上手和开发。

本教程包括6部分，构建模型、下载数据集、训练，定义servable json, 启动服务器和推理，其中服务器将在一个子进程中启动。

Hi,@xinwenh , please pay attention to the specification of punctuation, sometimes it is 、 , sometimes , , it seems particularly unprofessional

lwdragon · 2022-01-26T14:10:53Z

docs/zh_CN/source/quickstart/quickstart_in_one_minute.ipynb

   "metadata": {},
   "source": [
    "### 6. 推理\n",
    "\n",
    "#### 6.1 上传图片\n",
    "\n",
-    "用户需要上传一张0~9之间的数字图片作为输入。如果使用命令行终端，可以使用'scp'或者'wget'获取图片，如果使用Jupyter，点击菜单右上方的'Upload'按钮并且选择上传的图片。本教程中使用的图片可以点击[这里](https://ascend-tutorials.obs.cn-north-4.myhuaweicloud.com/tinyms-test-pics/numbers/7.png)进行下载，将图片保存在根目录下，重命名为'7.png'（或者任何用户喜欢的名字）\n",
+    "用户需要上传一张0~9之间的数字图片作为输入。如果使用命令行终端，可以使用'scp'或者'wget'获取图片，如果使用Jupyter，点击菜单右上方的'Upload'按钮并且选择上传的图片。本教程中使用的图片可以点击[这里](https://ascend-tutorials.obs.cn-north-4.myhuaweicloud.com/tinyms-test-pics/numbers/7.png)进行下载，将图片保存在根目录下，重命名为'7.png'（或者任何用户喜欢的名字）。\n",


Hi,@xinwenh.In order to unify the specification, it is recommended to change 'scp' and 'wget' to scp and wget

hellowaywewe

@xinwenh LGTM. Thanks for your contribution.

lwdragon · 2022-01-27T01:34:14Z

Hi,@xinwenh.The best path is to use ``, for example, change /home/jovyan to /home/jovyan.

hellowaywewe

LGTM

lwdragon

LGTM

lwdragon · 2022-01-27T02:24:15Z

@xinwenh LGTM. Thanks for your contribution.

lwdragon reviewed Jan 26, 2022

View reviewed changes

xinwenh commented Jan 26, 2022

View reviewed changes

tinyms-ai deleted a comment from hellowaywewe Jan 26, 2022

hellowaywewe reviewed Jan 26, 2022

View reviewed changes

docs/zh_CN/source/quickstart/quickstart_in_one_minute.ipynb Outdated Show resolved Hide resolved

hellowaywewe reviewed Jan 26, 2022

View reviewed changes

xinwenh requested review from hellowaywewe and lwdragon January 26, 2022 06:02

xinwenh force-pushed the xinwenh_branch branch 3 times, most recently from 0519d96 to c95ccc0 Compare January 26, 2022 12:04

hellowaywewe reviewed Jan 26, 2022

View reviewed changes

lwdragon reviewed Jan 26, 2022

View reviewed changes

xinwenh force-pushed the xinwenh_branch branch 2 times, most recently from 9088cbf to 647cd0a Compare January 26, 2022 18:23

hellowaywewe previously approved these changes Jan 27, 2022

View reviewed changes

Implementing an Image Classification App in One Minute for TinyMS 0.3.1

cbe5209

xinwenh dismissed hellowaywewe’s stale review via cbe5209 January 27, 2022 01:55

xinwenh force-pushed the xinwenh_branch branch from 647cd0a to cbe5209 Compare January 27, 2022 01:55

hellowaywewe approved these changes Jan 27, 2022

View reviewed changes

lwdragon approved these changes Jan 27, 2022

View reviewed changes

hellowaywewe merged commit c980ece into tinyms-ai:main Jan 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implementing an Image Classification App in One Minute for TinyMS 0.3.1 #140

Implementing an Image Classification App in One Minute for TinyMS 0.3.1 #140

xinwenh commented Jan 25, 2022

hellowaywewe commented Jan 26, 2022

lwdragon Jan 26, 2022

xinwenh Jan 26, 2022

xinwenh Jan 26, 2022

hellowaywewe Jan 26, 2022

lwdragon commented Jan 26, 2022

hellowaywewe Jan 26, 2022

hellowaywewe Jan 26, 2022

hellowaywewe Jan 26, 2022

hellowaywewe Jan 26, 2022

lwdragon Jan 26, 2022

lwdragon Jan 26, 2022 •

edited

Loading

lwdragon Jan 26, 2022

hellowaywewe left a comment

lwdragon commented Jan 27, 2022

hellowaywewe left a comment

lwdragon left a comment

lwdragon commented Jan 27, 2022

Implementing an Image Classification App in One Minute for TinyMS 0.3.1 #140

Implementing an Image Classification App in One Minute for TinyMS 0.3.1 #140

Conversation

xinwenh commented Jan 25, 2022

hellowaywewe commented Jan 26, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lwdragon commented Jan 26, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lwdragon Jan 26, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hellowaywewe left a comment

Choose a reason for hiding this comment

lwdragon commented Jan 27, 2022

hellowaywewe left a comment

Choose a reason for hiding this comment

lwdragon left a comment

Choose a reason for hiding this comment

lwdragon commented Jan 27, 2022

lwdragon Jan 26, 2022 •

edited

Loading