build: Upgrade to latest Electron stable #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickzhao
approved these changes
Jul 17, 2023
|
Merged in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sleuth is currently running on Electron v13.3.0, which is not a stable version (see here). To stay up to date with security best practices, bug fixes, performance enhancements and future maintenance, upgrading Sleuth to the latest stable version is needed.
This PR upgrades Sleuth to Electron v25.2.0 (latest at this time) and fixes #68
Notes
DevMode, a white window will appear for a few seconds before Sleuth appears. This doesn't appear in production and doesn't impact performance.app.allowRendererProcessReuseas it is no longer supported and was removed in Electron v14.0.0cachefromtype nameas it was removed fromapp.getPathherenew-windowfunction due tonew-windowevent being deprecated in Electron 13 and removed in Electron 22ARE_YOU_BUSYIPC Event and associated functions due to being unused and dead-code