Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(log-table): useful context menus #169

Merged
merged 4 commits into from
Jul 23, 2024
Merged

feat(log-table): useful context menus #169

merged 4 commits into from
Jul 23, 2024

Conversation

erickzhao
Copy link
Member

@erickzhao erickzhao commented Jul 16, 2024 •
edited
Loading

This PR adds context menus to log tables in Sleuth.

Menu items added:

  • Copy Line: copies the line to your clipboard
  • Show Line in Source: shows the log line in the source code of your default editor.
  • Show in "All Desktop Logs" (desktop logs only): finds the corresponding log line in "All Desktop Logs" and jumps to the context.
Screen.Recording.2024-07-16.at.14.50.16.mov

@erickzhao erickzhao marked this pull request as ready for review July 16, 2024 21:43
samuelmaddock
samuelmaddock approved these changes Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@samuelmaddock samuelmaddock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactoring and simple implementation 👍

I especially like the Show in "All Desktop Logs" functionality :)

src/renderer/ipc.ts Outdated Show resolved Hide resolved
@erickzhao @samuelmaddock
Update src/renderer/ipc.ts
06ae8c8 
Co-authored-by: Sam Maddock <smaddock@slack-corp.com>
@erickzhao erickzhao merged commit 3654c7c into main Jul 23, 2024
6 checks passed
@erickzhao erickzhao deleted the feat/context-menus branch July 23, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelmaddock samuelmaddock samuelmaddock approved these changes

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

@nocturnll nocturnll Awaiting requested review from nocturnll

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erickzhao @samuelmaddock