-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Main window cannot open after escape key pressed #472
Conversation
After this PR #448 , we now no longer need to destroy the main window in most cases, such as by clicking the close button in the upper left corner, or the escape key. To simplify the logic, I think we can remove the I simply tested it and it works.
- (EZFixedQueryWindow *)fixedWindow {
if (!_fixedWindow) {
_fixedWindow = [EZFixedQueryWindow shared];
_fixedWindow.releasedWhenClosed = NO;
}
return _fixedWindow;
} |
You are right. It's a better approach. |
This reverts commit 707989b.
@phlpsong Sorry, I didn't consider it thoroughly before. In some cases, it is not necessary to close the main window, such as when the main window loses focus or when opening App links. I have improved the code by adding The specific usage here is a bit complex, please test the effect of the code carefully. |
Easydict/Feature/ViewController/Window/WindowManager/EZWindowManager.m
Outdated
Show resolved
Hide resolved
Easydict/Feature/ViewController/Window/WindowManager/EZWindowManager.m
Outdated
Show resolved
Hide resolved
Looks good. I have left some comments and would appreciate it if you could clarify them. |
close #471