Add Helm chart support

[victorgetz]

Hi i think you need a helm chart :)
This one should do it

[codecov-io]

Codecov Report

Merging #24 (4757926) into master (bdf0891) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #24   +/-   ##
=======================================
  Coverage   56.36%   56.36%           
=======================================
  Files           4        4           
  Lines         165      165           
=======================================
  Hits           93       93           
  Misses         63       63           
  Partials        9        9           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdf0891...4757926. Read the comment docs.

[SantiEich]

Amazing, thanks!

[victorgetz]

For sure you will need also helm lint and all the other CI stuff but i would make for that a additional pull request since i don't know if you are interested or not

[yahel2410]

Hey, do you plan to merge this one? We would be interested to try imagepullsecret-patcher and helm chart is highly preferred

[victorgetz]

Hi i created also a pipeline for a github pages helm chart repo so everyone can just do this:

$ helm repo add titansoft-pte-ltd titansoft-pte-ltd/imagepullsecret-patcher
$ helm search repo titansoft-pte-ltd
$ helm install -n imagepullsecret-patcher --create-namespace imagepullsecret-patcher titansoft-pte-ltd/imagepullsecret-patcher --set dockerConfigJsonBase64Encoded="REPLACE_ME"

You just need to create a "gh-pages" branch in your repository.

I also created a test pipeline for the helm chart.

[victorgetz]

ping owner @billjh yes? no?

[Morriz]

Darn, I just created one myself too ;p Should have looked at the issues list before hacking away. Took me an hour tho.

Anyway, I have a simplification to add to avoid the steps to create the pullsecret in the first place:

{{/*
Create the docker pull secret from the creds
*/}}
{{- define "dockercfg" -}}
{"auths":{"{{ .server | default "docker.io" }}":{"username":"{{ .username }}","password":"{{ .password | replace "\"" "\\\"" }}","email":"{{ .email | default "not@us.ed" }}","auth":"{{ print .username ":" .password | b64enc}}"}}}
{{- end -}}

[victorgetz]

I will close the Pull request since imagepullsecret-patcher does not really solve the problem. If the container is started before the patch happens then there is still a imagepullbackoff.

i went with a docker mirror proxy (harbor) + kubernetes crds webhook

[Morriz]

I will close the Pull request since imagepullsecret-patcher does not really solve the problem. If the container is started before the patch happens then there is still a imagepullbackoff.

I also have some issues with the solution here, but your reason is not valid imo, as k8s reconciles repeatedly back-offishly.

i went with a docker mirror proxy (harbor) + kubernetes crds webhook

Pull through proxy like harbor is what we are also configuring, with many benefits. We have a nice stack integrated in redkubes/otomi now. Harbor preconfigured already but not yet as fully automated pull through proxy.