Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two issues in
System#decompress_file
that Appveyor caught while running thescreen-recorder
specs (log):url
is referenced instead offile_name
when raising an error. Seems like a copy-paste error to me :).install_dir
relative to the project root is used instead of the default one,target
resolves to theinstall_dir
+ the driver binary. For example,..\webdrivers_bin\chromedriver.exe
. This causes a problem on Windows where the absolute path now resolves toD:\<project>\webdrivers_bin\webdrivers_bin\chromedriver.exe
instead ofD:\<project>\webdrivers_bin\chromedriver.exe
, andFile.exist?
returns false for this.The fix is to check for the
basename
(*.exe) instead of the fulltarget
path. This works becauseDir.pwd
is the webdrivers install dir when this check is performed inSystem#decomress_file
.