Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default cache time to 24 hours. #133

Merged
merged 3 commits into from
Jun 11, 2019
Merged

Default cache time to 24 hours. #133

merged 3 commits into from
Jun 11, 2019

Conversation

kapoorlakshya
Copy link
Collaborator

Fixes #132.

This is the new/fixed order of precedence to determine the cache time:

  1. Value from environment variable WD_CACHE_TIME
  2. User defined, project specific cache time via Webdrivers.cache_time=
  3. Default value of 86,400 Seconds (24 hours)

@kapoorlakshya kapoorlakshya merged commit a287cad into titusfortner:master Jun 11, 2019
@kapoorlakshya kapoorlakshya deleted the 132_default_cache_time branch June 11, 2019 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titusfortner titusfortner titusfortner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default caching (documentation?) issues
2 participants
@kapoorlakshya @titusfortner