Add support for Apple M1 architecture (chromedriver) #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelHoste
changed the title
MichaelHoste
changed the title
kapoorlakshya
requested changes
Jan 8, 2021
There was a problem hiding this comment.
@MichaelHoste Thank you very much for the PR! Left two comments, but the overall approach looks good to me.
lib/webdrivers/chromedriver.rb
Outdated
| @@ -96,7 +104,9 @@ def download_url | |||
| normalize_version(required_version) | |||
| end | |||
|
|
|||
| file_name = System.platform == 'win' || System.wsl? ? 'win32' : "#{System.platform}64" | |||
| archi = apple_m1_cpu? && apple_m1_compatible?(version) ? '_m1' : '' | |||
There was a problem hiding this comment.
Can we please rename archi to apple_arch or mac_arch since it's specific to macOS/apple? Another option is to pull out the filename logic into a separate method to keep the complexity low.
|
I did what you suggested, it made sense! I first tried to create a separate method for the storage file name, but since we need to pass |
|
@MichaelHoste Thank you for making the changes. Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #191
I hope it's the correct approach.
It's still compatible with Chromedriver versions lower than
87.0.4280.88but it will then fallback to the Intel version of Chrome.