Fix circular require between webdrivers.rb and railtie.rb #233
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
webdrivers.rb
requireswebdrivers/railtie.rb
,webdrivers/lib/webdrivers.rb
Line 7 in 161d1bb
and
webdrivers/railtie.rb
requireswebdrivers.rb
.webdrivers/lib/webdrivers/railtie.rb
Line 3 in 161d1bb
This causes
warning: loading in progress, circular require considered harmful
warning from the Ruby interpreter.Here's a minimum step to reproduce.
This patch fixes the warning by simply removing the
require
call inwebdrivers/railtie.rb
, since there won't be any actual use case where directly requiringwebdrivers/railtie.rb
without requiringwebdrivers.rb
(via bundler in most cases).