Fixes downloading on m1 macs from version 106.0.5249.61 #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changed my gemfile to utilize this branch with |
|
@jmccure Thanks for your contribution! Merging to get a release out. Would appreciate a follow up with tests for |
|
Thanks @kapoorlakshya , will submit tests also |
|
@jmccure Awesome! v5.2.0 has been released. @carolyncole Thanks for testing this! |
|
late but have tested and it works |
facebook-github-bot
pushed a commit
to facebook/yoga
that referenced
this pull request
Oct 13, 2022
Summary: This adds the fixtures from #1116 and generates tests. This adds a good amount of coverage, but I plan to follow up with a diff adding a bit more, e.g. for interactions with flex direction of column when we should no-op, etc. I also discovered the current fixtures do not allow testing shorthand props like "gap" without changes. This also updates the `webdrivers` gem to respond to a break with chromedriver on m1 macs from 4 days ago titusfortner/webdrivers#239. Reviewed By: yungsters Differential Revision: D39922413 fbshipit-source-id: dfc7bda894be8dfcb24e25c19a4df0b09a72ce7e
hank-spokeo
pushed a commit
to hank-spokeo/webdrivers
that referenced
this pull request
Nov 15, 2022
…#239) Co-authored-by: Jay McCure <jmccure@gitlab.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #237