Fixes downloading on m1 macs from version 106.0.5249.61 onwards #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@frenesim I don't think this really changes anything. The only change is the method name and changing the strings to double quotes. What error are you fixing? The two latest chromedriver versions have the same filename suffix.
Are you using the latest version of this gem? Also I have tests that don't test the private methods in #240 |
|
You are right. I thought I had the latest version, but no. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a similar Issue to #237
The download is failing again for the newer chrome version. From version 106.0.5249.61 onwards seems the filename is 'chromedriver_mac_arm64.zip'.
https://chromedriver.storage.googleapis.com/
Let me know if we should open an issue to this one.
I found testing this change a bit hard, so I went on testing a private method 💀 . I tested the method I perceive as the best candidate to be the public API of a new class.