Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on net_http_ssl_fix. Update README. Fixes #59. #60

Merged
merged 2 commits into from
Apr 9, 2019
Merged

Conversation

ioquatix
Copy link
Contributor

@ioquatix ioquatix commented Apr 5, 2019

No description provided.

@kapoorlakshya
Copy link
Collaborator

kapoorlakshya commented Apr 5, 2019

TODO for me:

  • Update wiki entry when this gets merged.

@kapoorlakshya
Copy link
Collaborator

@ioquatix Can you please squash your commits locally and force push? Also, thanks for updating the heading sizes in the README. They look fine on my 4K monitor, but look huge when I now see it at 1080p or lower.

@ioquatix
Copy link
Contributor Author

ioquatix commented Apr 5, 2019

I was going to do a separate PR for the README but in the end it was such a small change.

The usage of nested # is pretty standard for markdown, and maps to <h1>...<h6> depending on the number of #. It shouldn't look any different on different resolutions excepting how your OS handles scaling of fonts.

@ioquatix
Copy link
Contributor Author

ioquatix commented Apr 5, 2019

Can you please squash your commits locally and force push.

You can do this when you choose "Squash & Merge" from the merge options. GitHub will do it automatically.

@kapoorlakshya
Copy link
Collaborator

You can do this when you choose "Squash & Merge" from the merge options. GitHub will do it automatically.

You're right. I keep forgetting about it.

@titusfortner
Copy link
Owner

Oh, I'm blind and didn't see the PR, just the issue. Completely agree this is better.

Do we want to go further and tell users in the README that while it is probably the easiest solution, it might not be the best solution?

@titusfortner titusfortner self-requested a review April 8, 2019 19:12
@kapoorlakshya
Copy link
Collaborator

kapoorlakshya commented Apr 8, 2019

Do we want to go further and tell users in the README that while it is probably the easiest solution, it might not be the best solution?

Yeah, may as well, and include a link to this page for more info - https://guides.rubygems.org/ssl-certificate-update/

@ioquatix
Copy link
Contributor Author

ioquatix commented Apr 9, 2019

I'll leave this in your hands.

@kapoorlakshya kapoorlakshya merged commit 7dfe67b into titusfortner:master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants