Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with selenium-webdriver master/v4 #69

Merged
merged 1 commit into from
Apr 17, 2019

Conversation

twalpole
Copy link
Collaborator

Use the ability to set a proc for driver_path if available

@kapoorlakshya
Copy link
Collaborator

Thanks, @twalpole!

Note to self: This relates to SeleniumHQ/selenium#7106

@twalpole
Copy link
Collaborator Author

twalpole commented Apr 17, 2019

@kapoorlakshya Yeah -- we need to get this merged and a new webdrivers released before selenium-webdriver 3.141.59 is released, otherwise anyone who updates selenium-webdriver and uses webdrivers will have failures

@kapoorlakshya
Copy link
Collaborator

I agree. Will release this in v3.8.0 along with #68.

@kapoorlakshya kapoorlakshya merged commit 801c6f9 into titusfortner:master Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants