Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v3i/simd]: Implement load_lane instructions #130

Merged
merged 1 commit into from
Nov 6, 2023
Merged

[v3i/simd]: Implement load_lane instructions #130

merged 1 commit into from
Nov 6, 2023

Conversation

haoyu-zc
Copy link
Contributor

@haoyu-zc haoyu-zc commented Nov 4, 2023 •
edited
Loading

Used bit manipulation instead of arrays as I did in my first attempt.

As discussed, the unboxing step is not necessary. But removing it involves factoring out doLoad. Will create a new PR for this later.

Tested by

make -j && bin/spectest.x86-linux -tk test/regress/simd/simd_load64_lane.bin.wast
make -j && bin/spectest.x86-linux -tk test/regress/simd/simd_load32_lane.bin.wast
make -j && bin/spectest.x86-linux -tk test/regress/simd/simd_load16_lane.bin.wast
make -j && bin/spectest.x86-linux -tk test/regress/simd/simd_load8_lane.bin.wast

titzer
titzer approved these changes Nov 6, 2023
View reviewed changes
Copy link
Owner

@titzer titzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@titzer titzer merged commit 34ab694 into titzer:master Nov 6, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titzer titzer titzer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haoyu-zc @titzer