Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctness tests for whamm probes #224

Merged
merged 20 commits into from
Nov 20, 2024
Merged

Correctness tests for whamm probes #224

merged 20 commits into from
Nov 20, 2024

Conversation

ejrgilbert
Copy link
Contributor

@ejrgilbert ejrgilbert commented Nov 18, 2024 •
edited
Loading

TODO:

  • write the tests
  • add test script
    - document issues as failures.* files
    - use the different tiers! (JIT/no-JIT)
  • add in matthew's tests from other PR

@ejrgilbert ejrgilbert changed the title Add in some correctness tests for whamm probes Correctness tests for whamm probes Nov 18, 2024
titzer
titzer reviewed Nov 19, 2024
View reviewed changes
Copy link
Owner

@titzer titzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a shell script similar to the one in test/wizeng/test.sh? (In fact, you could probably copy that and start from it).

test/whamm/jit/correctness/req-data/localN.wasm Outdated Show resolved Hide resolved
@ejrgilbert ejrgilbert mentioned this pull request Nov 19, 2024
Closed
@ejrgilbert ejrgilbert marked this pull request as ready for review November 20, 2024 21:36
titzer
titzer approved these changes Nov 20, 2024
View reviewed changes
Copy link
Owner

@titzer titzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, VARRY NAACE

@titzer titzer merged commit 5dabe04 into titzer:master Nov 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titzer titzer titzer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ejrgilbert @titzer