Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chunk dependency graph doesn't support circular dependencies #539

Closed
tivac opened this issue Jan 17, 2019 · 0 comments · Fixed by #541
Closed

Chunk dependency graph doesn't support circular dependencies #539

tivac opened this issue Jan 17, 2019 · 0 comments · Fixed by #541
Assignees
@tivac
Labels
bug pkg:rollup

Comments

@tivac
Copy link
Owner

tivac commented Jan 17, 2019

Expected Behavior

Chunks with circular dependencies between chunks are supported by rollup, and they should also be suppored by the @modular-css/rollup plugin.

Current Behavior

It throws a circular dependency error.

Possible Solution

new DepGraph({ circular : true }) should fix it.

Steps to Reproduce (for bugs)

  1. Set up a project with dynamic imports that have circular dependencies using @modular-css/rollup
  2. Run a build

Context

Can't run any builds since they error out every time.

Your Environment

Executable Version
modular-css 20.0.1
npm --version 6.5.0
node --version 10.12.0
OS Version
Windows 10 1607
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tivac tivac

Labels
bug pkg:rollup
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support circular dependencies tivac/modular-css
1 participant
@tivac