-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Rollup@1.0 support #532
Conversation
Since removing can be lossy, flagging files is a safer approach.
Also moved output line to be more consistent with expecations.
Codecov Report
@@ Coverage Diff @@
## master #532 +/- ##
==========================================
+ Coverage 99.11% 99.13% +0.01%
==========================================
Files 39 40 +1
Lines 907 922 +15
Branches 135 138 +3
==========================================
+ Hits 899 914 +15
Misses 8 8
Continue to review full report at Codecov.
|
BTW not deleting files is quite in line with what rollup does i.e. just use hashes in watch mode, make some changes and watch your target directory fill up... I guess we need a dedicated cleanup plugin that uses the "manifest" you get in the generateBundle hook to clean up the diffing files. That is if you use the asset emission API. |
When invalidation was added in #532 I apparently forgot to account for it withiin the dependency walking code, so invalidated files wouldn't ever be rewalked. This has likely been causing a variety of nasty-to-debug errors in the wild 😞
When invalidation was added in #532 I apparently forgot to account for it withiin the dependency walking code, so invalidated files wouldn't ever be rewalked. This has likely been causing a variety of nasty-to-debug errors in the wild 😞
When invalidation was added in #532 I apparently forgot to account for it withiin the dependency walking code, so invalidated files wouldn't ever be rewalked. This has likely been causing a variety of nasty-to-debug errors in the wild 😞
When invalidation was added in #532 I apparently forgot to account for it withiin the dependency walking code, so invalidated files wouldn't ever be rewalked. This has likely been causing a variety of nasty-to-debug errors in the wild 😞
Had to change how the plugin reported dependencies, as well as invent a new way of marking files as being replaceable in
processor.invalidate()
. Used to just.remove()
them but thetransform
hook isn't getting called for unchanged files again, presumably due to the caching layer.This has the downside of never removing files when they've been deleted/renamed, but I think that's probably ok? We'll see! At the very least it won't be a breaking change to add functionality to check for the file on disk when the
watchChange
event fires and then removing files that are gone after we've invalidated them.