Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try fix app docker image #13

Merged
merged 3 commits into from
Mar 18, 2023
Merged

Try fix app docker image #13

merged 3 commits into from
Mar 18, 2023

Conversation

WebGL3D
Copy link
Contributor

@WebGL3D WebGL3D commented Mar 18, 2023

What 🔨

Definitely should have tested this before committing #11. Apparently the file versioning for the package.json file uses npm link, which copies over the node_modules from the library, and then causes mass destruction.
See also: facebook/react#24928 (comment)

Fix 📦

To fix the docker image, and allow us to use the local module, we can build the module separate from app itself, and then copy over (exclusively) the distributable files into the app build image.

Unrelated 🏷️

I also removed some references that referred to this repository with the -demo suffix, since we renamed the repository to.. no longer have that suffix.

Broken 🙈

Still broken is the ability to run the app via Visual Studio code, because the npm link call breaks the app as-is.

@WebGL3D WebGL3D marked this pull request as ready for review March 18, 2023 20:46
@WebGL3D WebGL3D merged commit 8e046a4 into main Mar 18, 2023
@WebGL3D WebGL3D deleted the feature/keep-fixing branch March 18, 2023 20:49
@WebGL3D
Copy link
Contributor Author

WebGL3D commented Mar 18, 2023

The current workaround for running locally in VS code:

npm uninstall @tix-factory/push-notifications
npm install @tix-factory/push-notifications

This will remove the file link, and then reinstall, downloading the module from npmjs. Of course this means local module changes won't be seen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant