Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What 🔨
Definitely should have tested this before committing #11. Apparently the
file
versioning for thepackage.json
file usesnpm link
, which copies over thenode_modules
from the library, and then causes mass destruction.See also: facebook/react#24928 (comment)
Fix 📦
To fix the docker image, and allow us to use the local module, we can build the module separate from app itself, and then copy over (exclusively) the distributable files into the
app
build image.Unrelated 🏷️
I also removed some references that referred to this repository with the
-demo
suffix, since we renamed the repository to.. no longer have that suffix.Broken 🙈
Still broken is the ability to run the app via Visual Studio code, because the
npm link
call breaks the app as-is.