Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add spaces between extra arguments to prevent errors #125

Merged
merged 2 commits into from
Aug 20, 2023
Merged

fix: add spaces between extra arguments to prevent errors #125

merged 2 commits into from
Aug 20, 2023

Conversation

mdonahue-godaddy
Copy link
Contributor

  • Add space prefix to each argument when appending to EXTRA_ARGS. (note: This is only necessary when you specify 2 or more input values.)

github-actions[bot]
github-actions bot reviewed Aug 18, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing a fix, could you ensure that the test covers your changes if applicable.

@jackton1 jackton1 changed the title BugFix: When setting two or more inputs, EXTRA_ARGS needs space delimiters or it will error. fix: add spaces between extra arguments to prevent errors Aug 20, 2023
@jackton1
Copy link
Member

Nice catch @mdonahue-godaddy

@jackton1
Copy link
Member

@all-contributors please add @mdonahue-godaddy for bug,code

@allcontributors allcontributors bot mentioned this pull request Aug 20, 2023
Merged
@allcontributors
Copy link
Contributor

@jackton1

I've put up a pull request to add @mdonahue-godaddy! 🎉

@jackton1 jackton1 merged commit 23e9b07 into tj-actions:main Aug 20, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@jackton1 jackton1 jackton1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdonahue-godaddy @jackton1