Comment out new misuse check until a major version (#2026)

tj · Oct 7, 2023 · 67c9180 · 67c9180
1 parent 96c6c25
commit 67c9180
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/lib/command.js b/lib/command.js
@@ -751,9 +751,9 @@ Expecting one of '${allowedValues.join("', '")}'`);
     if (this.options.length) {
       throw new Error('call .storeOptionsAsProperties() before adding options');
     }
-    if (Object.keys(this._optionValues).length) {
-      throw new Error('call .storeOptionsAsProperties() before setting option values');
-    }
+    // if (Object.keys(this._optionValues).length) {
+    //   throw new Error('call .storeOptionsAsProperties() before setting option values');
+    // }
     this._storeOptionsAsProperties = !!storeAsProperties;
     return this;
   }

diff --git a/tests/commander.configureCommand.test.js b/tests/commander.configureCommand.test.js
@@ -85,10 +85,10 @@ test('when storeOptionsAsProperties() after adding option then throw', () => {
   }).toThrow();
 });
 
-test('when storeOptionsAsProperties() after setting option value then throw', () => {
-  const program = new commander.Command();
-  program.setOptionValue('foo', 'bar');
-  expect(() => {
-    program.storeOptionsAsProperties();
-  }).toThrow();
-});
+// test('when storeOptionsAsProperties() after setting option value then throw', () => {
+//   const program = new commander.Command();
+//   program.setOptionValue('foo', 'bar');
+//   expect(() => {
+//     program.storeOptionsAsProperties();
+//   }).toThrow();
+// });