solve #306, and bin in $PATH make sense now #307
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have no idea how to compatible with Windows here #142 |
|
Now windows also make sense. I will write some tests for this later. |
| var local = path.join(dir, bin); | ||
| if (fs.existsSync(local)) bin = local; |
There was a problem hiding this comment.
@rlidwka Not yet heard that, Thanks a lot. Maybe we can replace it with fs.accessSync after v0.12, but it makes sense now.
called "nodejs", and on windows it might be renamed too because of the conflict with node.exe service from microsoft. thx @rlidwka
|
Looks like this fixes more than one edge case. Can we get the tests passing? |
called "nodejs", and on windows it might be renamed too because of the conflict with node.exe service from microsoft. thx @rlidwka
| var proc = spawn('node', args, { stdio: 'inherit', customFds: [0, 1, 2] }); | ||
|
|
||
| var proc; | ||
| if (process.platform !== 'win32') { |
There was a problem hiding this comment.
With the commit, bin file must have shebang itself
|
Closed for too many commits. I'll open another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solve #306, and bin in $PATH make sense now #196
Almost revert #173 which lead to the bug in #306
Also remove deprecated
customFdsoption in spawn