Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added optional callback to help functions #434

Closed
wants to merge 5 commits into from
Closed

Conversation

djulien
Copy link
Contributor

@djulien djulien commented Sep 12, 2015

Added an optional callback to the help functions to allow post-processing of help text before it is displayed.

added a callback to allow auto-generated help text to be filtered or
post-processed.  for example, i want to apply colors to the text before
it is displayed in the console.

add callback to allow filtering or post-processing of help text
added a callback to allow auto-generated help text to be filtered or
post-processed.  for example, i want to apply colors to the text before
it is displayed in the console.

add callback to allow filtering or post-processing of help text
make brace alignment in example consistent with other code
@SomeKittens
Copy link
Collaborator

Change looks good, can you not update the version in package.json just yet?

@djulien
Copy link
Contributor Author

djulien commented Sep 13, 2015

Sorry - I thought any change to behavior was supposed to have a version# change as well.
Should I just commit a new change on top of it to put it back? (I don't know all the fancy branching and merging git procedures, just the basics)

@SomeKittens
Copy link
Collaborator

you're totally correct about versioning, just that it's up to the project maintainers to cut a release. If you can, squash your changes down to one commit. (good time to learn about git reset)

@djulien
Copy link
Contributor Author

djulien commented Sep 14, 2015

I looked up reset but wasn't comfortable with the head#. I also found something called "interactive rebase" which sounded like it would allow me to just drop the version# part of the changes, so I gave that a try. Does the commit look okay now, or do I still need to merge it all into one?

@SomeKittens
Copy link
Collaborator

Ah, I'll just squash 'em.

@SomeKittens
Copy link
Collaborator

Alright, all squished and joined in 4d421f9

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants