Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use swig-templates module #284

Merged
merged 6 commits into from
Sep 20, 2017
Merged

Conversation

fatihky
Copy link
Contributor

@fatihky fatihky commented Jul 4, 2017

since swig module is unmaintained, there is a maintained fork exists.

@doowb
Copy link
Collaborator

doowb commented Sep 18, 2017

@fatihky thanks for the PR.

Can you change this so both options are available and the user can decide which one they want to use? This will be similar to jade and pug that try to require in pug and if that fails, then requires in then-pug.

Then you can include the swig-templates link in the readme after the unmaintained swig link.

@fatihky
Copy link
Contributor Author

fatihky commented Sep 19, 2017

Hey @doowb, I made changes prior to your comment. Could you check them out if these ok?

@doowb
Copy link
Collaborator

doowb commented Sep 20, 2017

@fatihky this looks great, thanks!

@doowb doowb merged commit 97c36e0 into tj:master Sep 20, 2017
@fatihky
Copy link
Contributor Author

fatihky commented Sep 20, 2017

thank you @doowb!

@fatihky fatihky deleted the fatihky-swig-maintained-fork branch September 20, 2017 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants