Additional files in migrations folder

[saveman71]

I'm currently "migrating" (🥁) our migrate installation from 0.1.6 to the latest. I have some helpers files (e.g. migrations/helpers.js that is required in almost every migration I create.

However it seems it's trying to use helpers.js as a migration file now (Migration helpers.js does not have method up), whereas this file was ignored before.

It seems this use case is confirmed to be possible in the README:

node-migrate/Readme.md

Lines 84 to 88 in ee1df14

	```javascript
	// db is just an object shared between the migrations
	var db = require('./db');
	exports.up = function (next) {

What's the best way of fixing that?

Additionally I would also like to ignore all files in a subfolder (they seemed to be ignored previously as well)

[wesleytodd]

Yep this is one of the breaking changes. If you want to have other things in your migrations directory now you need to provide a filter function. This isn't well documented at the moment, but you would need to use the js api and wrap it in your own cli, as the filter is not currently exposed on the cli.

I think the best way is to move the extraneous stuff out of your migrations directory. Either that or submit a PR to expose the filter on the cli :) 🤞

[saveman71]

I agree moving them out seems like the better option. However I still think the doc (snippet I ref'd in #145 (comment)) is a bit misleading on that, as it seems it still should be possible without any further configuration.

Also, the breaking change wasn't mentioned in History.md :)

(no reproach at all btw, congrats on maintaining this properly already and answering this that fast 👏)

I might make a PR later in the week for these documentation fixes. If I don't do it feel free to go ahead!

[wesleytodd]

Hey @saveman71, no ill will taken! I changed so much in the 1.0 I am sure I missed some things in the history, which is why OSS and team work is great! A PR will be very welcome, but please be patient with me now because between my comment 6 days ago and yours 3 days ago I had a baby daughter (👶!!!) so will be a bit disconnected.

If you make a PR for the docs it would be great to also update the history file. Thanks!

[gustavopch]

If I understand correctly the issue, the desired feature already exists in the CLI as an option called matches.

migrate up --matches '^\d+-[\w-]+.js$'

See: https://github.com/tj/node-migrate/blob/master/bin/migrate-up#L25

[mkovel]

@gustavopch Unfortunately --matches logic was implemented base on minimatch and do not support full Regexp only glob and this example does not work
If i wrong, please let me know.

[monooso]

@gustavopch / @mkovel The --matches flag will suffice if you place all of your "helper" files in a sub-directory. For example:

migrate up --matches '!helpers'

[mkovel]

@gustavopch / @mkovel The --matches flag will suffice if you place all of your "helper" files in a sub-directory. For example:

migrate up --matches '!helpers'

good point. tnx