Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #148: Allow absolute path for migrations dir #149

Closed
wants to merge 2 commits into from
Closed

Issue #148: Allow absolute path for migrations dir #149

wants to merge 2 commits into from

Conversation

akivajgordon
Copy link
Contributor

Closes issue #148

  • Wrote the failing test first
  • made the fix
  • re-ran the tests, all passed.

@wesleytodd
Copy link
Collaborator

Good call. Only one nit pick, can you add a test in your new file for the relative behavior as well? That way we ensure we don't break either way moving forward. If you add that I will prepare a release for this soon, probably along with a few other things I have been planning on releasing in the next minor release.

@akivajgordon
Copy link
Contributor Author

@wesleytodd Done! Let me know if you have any other recommendations.

@wesleytodd
Copy link
Collaborator

Awesome, I will take a look at this tomorrow. Thanks for the contribution!

@akivajgordon
Copy link
Contributor Author

@wesleytodd Just checking in on this... anything I can do to help move this forward?

@wesleytodd
Copy link
Collaborator

Hey, I am so sorry that I dropped the ball on this. I was out for a bit having a child and I guess github cannot handle all the notifications, because it did not show me this one until now. I will take a look this weekend and we should be good to release! Again, sorry about the delay!

@wesleytodd wesleytodd closed this in 018e983 Jun 2, 2019
@akivajgordon
Copy link
Contributor Author

@wesleytodd No problem at all – congrats on your child! Wishing you all the best with that!

Thanks for merging.

@Jaskar14
Copy link

@wesleytodd Hey, is this option anywhere in the documentation? It was difficult to find without looking at issues/source code. If it isn't in the documentation, I can make a pr, but wanted to double check with you first

@wesleytodd
Copy link
Collaborator

PR is very welcome! Docs are all in the README.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants