Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated so that objects are default unless [] are empty and updated test... #98

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

silkcom
Copy link

@silkcom silkcom commented Mar 20, 2014

updated so that objects are default unless [] are empty and updated tests to verify it works

Basically the point of this is to make it work more like PHP and Rails.

Items[1]=on&items[4]=on

will now become:
{ items: { 1: on, 4: on } }

rather than
{ items: [on, on] }

Updated tests to make sure that it didn't mess up even when [] and [99999] was used.

items[]=on&items[]=on will still equal { items: [on, on] }

@silkcom
Copy link
Author

silkcom commented Mar 27, 2014

anything blocking this from being merged? I'd really like to remove the hacks that I have to add to my html

@buschtoens
Copy link
Collaborator

Will check this in about 4 hours. I'm on the move right now.

@silkcom
Copy link
Author

silkcom commented May 31, 2014

Has this been merged in? It still passes build tests right?

@moll
Copy link

moll commented Jun 7, 2014

Just stumbled upon this problem too that number-like keys are lost when between brackets. So, any news on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants