Vagrant fixes #576
Merged
Vagrant fixes #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
theo-o
commented
Sep 11, 2018
theo-o
commented
- Bump Vagrant requirement because of change in Vagrant download URL described here
- Add option to use the VPN
- Add option to use NFS
ovkulkarni
reviewed
Sep 11, 2018
|
|
||
| Vagrant.configure(VAGRANTFILE_API_VERSION) do |config| | ||
| Vagrant.configure("2") do |config| |
There was a problem hiding this comment.
Why change this to hard coded?
There was a problem hiding this comment.
It gets rid of a warning warning: already initialized constant VAGRANTFILE_API_VERSION. It also reflects the documented example at https://www.vagrantup.com/docs/vagrantfile/version.html.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.