feat!: rework input argument flags #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `--dir` flag as it's confusing to use. Adjust `--outdir` to create the directory name if it doesn't exist. Remove `--file` flag and make the filename a required input.
|
Hmmm, i don't think this handles everything we were handling before. The main problem is that we have to generate things differently for autoload code vs regular runtime files, so there is some initial handling of that in the previous version that is lost. |
|
Fair, but I also suspect that the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
--dirflag as it's confusing to use.Adjust
--outdirto create the directory name if it doesn't exist.Remove
--fileflag and make the filename a required input.