Remove overrides of isSymlink and isDirectory in VirtualActionInp…

…ut subclasses, they are all the same. PiperOrigin-RevId: 527891355 Change-Id: I3d1d9df72cca40079bb854d79053eee0cc4d95a4
tjgq · Apr 28, 2023 · 1b66046 · 1b66046
1 parent 38d2cce
commit 1b66046
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 32 deletions.
diff --git a/src/main/java/com/google/devtools/build/lib/actions/CommandLines.java b/src/main/java/com/google/devtools/build/lib/actions/CommandLines.java
@@ -288,16 +288,6 @@ public ParamFileActionInput withAdjustedArgs(Function<String, String> adjuster)
           charset);
     }
 
-    @Override
-    public boolean isDirectory() {
-      return false;
-    }
-
-    @Override
-    public boolean isSymlink() {
-      return false;
-    }
-
     @Override
     public void writeTo(OutputStream out) throws IOException {
       ParameterFile.writeParameterFile(out, arguments, type, charset);

diff --git a/src/main/java/com/google/devtools/build/lib/exec/BinTools.java b/src/main/java/com/google/devtools/build/lib/exec/BinTools.java
@@ -186,13 +186,6 @@ public void writeTo(OutputStream out) throws IOException {
       }
     }
 
-    @Override
-    public boolean isSymlink() {
-      // There are no unresolved symlinks embedded in the binary. We don't need them (embedded
-      // binaries are just a few simple tools) and zip doesn't support them anyway.
-      return false;
-    }
-
     @Override
     @CanIgnoreReturnValue
     protected byte[] atomicallyWriteTo(Path outputPath, String uniqueSuffix) throws IOException {
@@ -209,11 +202,6 @@ protected byte[] atomicallyWriteTo(Path outputPath, String uniqueSuffix) throws
       return digest;
     }
 
-    @Override
-    public boolean isDirectory() {
-      return false;
-    }
-
     @Override
     public ByteString getBytes() throws IOException {
       ByteString.Output out = ByteString.newOutput();

diff --git a/src/test/java/com/google/devtools/build/lib/actions/util/ActionsTestUtil.java b/src/test/java/com/google/devtools/build/lib/actions/util/ActionsTestUtil.java
@@ -365,16 +365,6 @@ public PathFragment getExecPath() {
         return path;
       }
 
-      @Override
-      public boolean isDirectory() {
-        return false;
-      }
-
-      @Override
-      public boolean isSymlink() {
-        return false;
-      }
-
       @Override
       public void writeTo(OutputStream out) throws IOException {
         out.write(contents.getBytes(UTF_8));