Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent panic when parsing a URL with no path #55

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: prevent panic when parsing a URL with no path #55

wants to merge 3 commits into from

Commits on Oct 25, 2024

  1. chore: sate clippy

    @CardboardTurkey
    CardboardTurkey committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    c88685b View commit details
    Browse the repository at this point in the history

  2. fix: prevent panic when parsing a URL with no path 

    Prior to this change `parse` would panic at `src/lib.rs:203:29` with
`index out of bounds: the len is 0 but the index is 0` if given an input
like "git:".
    @CardboardTurkey
    CardboardTurkey committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    dab8527 View commit details
    Browse the repository at this point in the history

  3. feat: improve error handling 

    This removes a seemingly redundant and not very illuminating error
variant. It also ensures that the error message from the `Url` crate is
displayed when displaying `UrlParseError`.
    @CardboardTurkey
    CardboardTurkey committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    f87f247 View commit details
    Browse the repository at this point in the history