Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strengthen short finish #229

Merged
merged 4 commits into from
Mar 29, 2024
Merged

Strengthen short finish #229

merged 4 commits into from
Mar 29, 2024

Conversation

tkaitchuck
Copy link
Owner

Fix two problems with the short_finish

  • If on ARM where the xor happens first the same value cannot be used for both parameters.
  • XOR the two halfs of the output to avoid the possibility that two bit diffs can cancel

Signed-off-by: Tom Kaitchuck <Tom.Kaitchuck@gmail.com>
* If on ARM where the xor happens first the same value cannot be used for both parameters.
* XOR the two halfs of the output to avoid the possibility that two bit diffs can cancel

Signed-off-by: Tom Kaitchuck <Tom.Kaitchuck@gmail.com>
Signed-off-by: Tom Kaitchuck <Tom.Kaitchuck@gmail.com>
Signed-off-by: Tom Kaitchuck <Tom.Kaitchuck@gmail.com>
@tkaitchuck tkaitchuck merged commit d1532cc into 0.9-prerelease Mar 29, 2024
@tkaitchuck tkaitchuck deleted the fast_path_test branch March 29, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant