Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web: Launch Options (Fixes #104) #109

Merged
merged 3 commits into from
Feb 9, 2023

Conversation

Foldex
Copy link
Contributor

@Foldex Foldex commented Feb 7, 2023

image

Fixes a conflict between base and full on the launch dialog, and adds radio button theming.

@tkashkin
Copy link
Owner

tkashkin commented Feb 7, 2023

"Always use this option" should probably be a checkbox.

The same applies to "Remember me" in the Login dialog (it is a checkbox already) and to DLC/Workshop checkboxes.

@tkashkin
Copy link
Owner

tkashkin commented Feb 7, 2023

Also do you have any ideas on how to make it look less weird when the options list is overflowing (screenshot in #104).
With your fix it should fit 4 options, but the problem will reappear with 5 or more.

In the worst case it should be possible to set border-radius for the whole scrollable container, but ideally the list should expand and not be scrollable at all if possible (unlikely).

@Foldex
Copy link
Contributor Author

Foldex commented Feb 9, 2023

image

Added the checkbox changes.

I did move some minor dialog changes to the base theme as well, but they're fairly deserved I think. Might be worth discussing if we want to move some other dialogs to it as well. The uninstall dialog for example.

Also do you have any ideas on how to make it look less weird when the options list is overflowing

I got nothing that isn't worse in other ways, might just have to bite the bullet. Five different launch options is a bit unlikely, and people are likely to hit the "always" option and not see it again anyway.

@Foldex Foldex mentioned this pull request Feb 9, 2023
@tkashkin tkashkin merged commit 976c45f into tkashkin:master Feb 9, 2023
@Foldex Foldex deleted the launch_options_fix branch May 5, 2023 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants