Fix: Do not overwrite args.target on Windows if value is set #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the unexpected behaviour on Windows that causes the args.target to always be overwritten. This effectively disables the --target argument on Windows, thus requiring manual edits to the constants to change the target destination path. This commit also changes the default behaviour on non-Windows systems, so that default values are no longer being strictly enforced when additional or explicit parameter values have been given for the --target argument.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description
Fixes the unexpected behaviour on Windows that causes the
args.targetalways to be overwritten, effectively disabling the--targetargument on Windows and requiring manual edits to the constants to change the target destination path.This PR also changes the default behaviour on non-Windows systems, so that default values are no longer being strictly enforced when additional or explicit parameter values have been given for the
--targetargument.How To Reproduce (Current Codebase)
install.pywith the--targetargument on Windows and supply a custom path.args.target.windows.How To Test (Pull Request)
2.1. Do not specify the
--targetargument.2.2. This will default to the values
normalandflatpak.2.3. Specify values for the
--targetargument (i.e.--target "flatpak" "/tmp/steam").2.4. Check
args.target, only the specified values are present.