Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Emulator: game file patterns also match directories as executable #258

Closed
hlechner opened this issue Jun 21, 2019 · 2 comments
Closed

Comments

@hlechner
Copy link

Expected behavior

When a pattern is defined on the following textbox:
image
The expected behavior is that only files will match this pattern

Actual behavior

It's actually matching the folders as well.

Steps to reproduce

I'm using Higan (emulator), and this emulator copy the roms on that directory structure:
<name of the console>/<name of the rom>/program.rom

In this example:
Super Famicom/Aladdin (USA).sfc/program.rom

Aladdin (USA).sfc is a folder but recognized as executable:
image

Version and environment
Version: 0.14.0-1543581-makepkg
Branch:  makepkg
Commit:  1543581 (154358158a1e1200a69ed3b35fbf338f68f29d13)
Distro:  NAME=Arch Linux
DE:      Yaru:ubuntu:GNOME
tkashkin added a commit that referenced this issue Jun 21, 2019
Do not try to show merged games when merging is disabled (#259)
@tkashkin
Copy link
Owner

It should be fixed.

@hlechner
Copy link
Author

It's fixed.

Lucki pushed a commit to Lucki/GameHub that referenced this issue Oct 30, 2021
Do not try to show merged games when merging is disabled (tkashkin#259)


Former-commit-id: b126539
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants