Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOSBox re-open when "exit" is executed on DOSBox window #275

Closed
hlechner opened this issue Jul 4, 2019 · 2 comments
Closed

DOSBox re-open when "exit" is executed on DOSBox window #275

hlechner opened this issue Jul 4, 2019 · 2 comments

Comments

@hlechner
Copy link

hlechner commented Jul 4, 2019

Expected behavior

With a DOSBox game without exit on .conf file is executed: when the game is finished it will go back to a DOS terminal, when you type: exit, the DOSBox should be closed.

Actual behavior

The moment you type: exit, the DOSBox closes, but GameHub re-open it.

The only way to actually closes it is by clicking on the close button of window border.

From debug messages it just repeat the [DEBUG] [Utils.run] {'/usr/bin/dosbox'... as the first time it executed it.

Steps to reproduce
  • Add a DOSBox game on GameHub (without .conf file or with a .conf file without an exit on it)
  • Execute the game
  • Exit the game by using the game's interface (returning to the DOSBox console)
  • On DOSBox console type: exit

It will close and re-open again.

Version and environment
Version: 0.14.1-b286d46-makepkg
Branch:  makepkg
Commit:  b286d46 (b286d467b67cae2f727105ae7a356a6bceec63c1)
Distro:  NAME=Arch Linux
DE:      Yaru:ubuntu:GNOME
@tkashkin
Copy link
Owner

tkashkin commented Jul 4, 2019

GameHub did process Enter key press and it restarted selected game. 1 second timeout is added after game finishes to prevent restarts like this.

@hlechner
Copy link
Author

hlechner commented Jul 4, 2019

I can confirm the fix worked

@hlechner hlechner closed this as completed Jul 4, 2019
Lucki pushed a commit to Lucki/GameHub that referenced this issue Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants