-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Random segmentation faults downloading games #67
Comments
Stacktraces are not so helpful because of use of ThreadPool and async methods (maybe even too many of async). It can be a bug in Trove parsing, games merging or anywhere else. It would help if bug's location was more specific. Try enabling/disabling some features/sources in settings to get some ideas of what can be broken. |
They started before the commit to implement Humble Trove, but now they are more frequent when you download that games. Maybe it will only happen if you have a large library like me? |
I have slightly changed merging and moved game info updating in a new thread which will run after loading for all games at once instead of updating each game while loadung. Does this bug appear with merging disabled? |
Yes, merged was always disabled. |
Try commenting |
Uhm, ArchLinux was stripping automatically the binaries of every package. I re-tested and the stacktrace is a little better:
|
Still not too useful stacktrace unfortunately. |
Yes. No crashes so far.. (but it needs more testing!) |
Interesting, I don't really know what exactly can break there. |
So, commenting |
It seems the reason of crashes is that update is happening in background thread, it triggers property change signals, UI widgets are listening these signals and are updating itself. Problem: UI updates from background thread can lead to unexpected problems and random crashes. I think the proper solution would be to somehow postpone UI updates and do them in UI thread when required. |
I got a new crash, using 1s of sleep time. I don't know if it is related:
|
Yes, seems to be related. It can crash randomly anywhere now. |
I have found (almost?) 100% reliable segfault when tags are removed from database and there are tags imported from GOG. It should make debugging this easier. |
Seems to be fixed by 5e03bce. |
😢
|
Test latest commit. |
Seems to be fixed with latest commit. |
"Installed" tag (tkashkin#69) Fix Utils.strip_name (tkashkin#70) Partly update localizations Former-commit-id: 5e03bce
Former-commit-id: 55fadbc
Latest revisions of the
dev
branch crashes randomly while I download games. I collected two stack traces. (however, despite I compiled with the--buildtype=debug
option, they don't show too much symbols):The text was updated successfully, but these errors were encountered: