-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Epic Games support #377
Conversation
id = idP; | ||
icon = ""; | ||
image = src.legendary_wrapper.get_image(id); | ||
platforms.add(Platform.LINUX); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Platform is wrong. It should be Windows but by default GameHub use Wine for that.
platforms.add(Platform.LINUX); | ||
|
||
install_dir = null; | ||
executable_path = "$game_dir/start.sh"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed
info = Tables.Games.INFO.get(s); | ||
info_detailed = Tables.Games.INFO_DETAILED.get(s); | ||
icon = Tables.Games.ICON.get(s); | ||
image = src.legendary_wrapper.get_image(id);//Tables.Games.IMAGE.get(s); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It change image with every reload. It should be possible to change it.
EpicGames epic = (EpicGames)(game.source); | ||
|
||
Utils.thread("EpicGamesGame.Installer", () => { | ||
game.status = new Game.Status(Game.State.DOWNLOADING, game, null); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should add progress bar change here. Should I create own Game.State or use existing in Downloader.
|
||
public class LegendaryWrapper | ||
{ | ||
private Regex regex = /\*\s*([^(]*)\s\(App\sname:\s([a-zA-Z0-9]+),\sversion:\s([^)]*)\)/; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New legendary has csv output. It should be changed.
var input = new DataOutputStream(process.get_stdin_pipe ()); | ||
var output = new DataInputStream(process.get_stdout_pipe ()); | ||
string? line = null; | ||
input.put_string("y\n"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-y for CLI will skip this question
var input = new DataOutputStream(process.get_stdin_pipe ()); | ||
var output = new DataInputStream(process.get_stdout_pipe ()); | ||
string? line = null; | ||
input.put_string("y\n"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-y for CLI will skip this question
af94e50
to
4446b93
Compare
Implemented some other features in the client
This one is actively developed: |
PR for #295. Work still in progress.
legendary
is installed to enable EpicGames GameSource