[Base] Stop pirating Base.sign

tkemmer · Oct 20, 2022 · 461ee0c · 461ee0c
1 parent f82723a
commit 461ee0c
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/docs/src/intern/base.md b/docs/src/intern/base.md
@@ -17,6 +17,7 @@
     _cos
     _dot
     _norm
+    _sign
     cathetus
     ddot
     distance
@@ -26,7 +27,6 @@
     props
     reverseindex
     seek
-    sign
     unpack
     vertexnormals
 ```
diff --git a/src/NESSie.jl b/src/NESSie.jl
@@ -2,7 +2,7 @@ __precompile__()
 
 module NESSie
 
-import Base: sign, seek
+import Base: seek
 import LinearAlgebra.BLAS: gemv!, gemv, axpy!, gemm
 
 using Distances: euclidean

diff --git a/src/base/util.jl b/src/base/util.jl
@@ -302,7 +302,7 @@ end
 
 # =========================================================================================
 """
-    sign{T}(
+    _sign{T}(
         u::AbstractVector{T},
         v::AbstractVector{T},
         n::AbstractVector{T}
@@ -315,7 +315,7 @@ same orientation, ``0`` if at least one of the vectors is zero, and ``-1`` other
 # Return type
 `T`
 """
-@inline function sign(
+@inline function _sign(
         u::AbstractVector{T},
         v::AbstractVector{T},
         n::AbstractVector{T}

diff --git a/test/base/util.jl b/test/base/util.jl
@@ -1,5 +1,5 @@
-using NESSie: _cos, _dot, _norm, eye!, pluseye!, isdegenerate, seek, reverseindex, unpack, vertexnormals, 
-    cathetus, sign, distance
+using NESSie: _cos, _dot, _norm, eye!, pluseye!, isdegenerate, seek, reverseindex, unpack,
+    vertexnormals, distance
 using LinearAlgebra: ⋅, norm
 
 @testset "_cos" begin
@@ -328,6 +328,6 @@ end
     end
 end
 
+@test_skip _sign
 @test_skip cathetus
-@test_skip sign
 @test_skip ddot