-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Freeze of VTK To Blender Volume during animation when frame changes with Update All Automatically selected #114
Comments
Thanks for the bug report and pull request #115 ! Were you able to find out the actual reason for the freeze? While #115 seems to provide a workaround, I'd prefer to fix the cause of freeze instead of adding new modes, if possible. I'm still trying to figure out the code, it has been a while since I looked at this code.. |
Hmm looks like freeze happens in calling bpy.ops.object.volume_import() https://docs.blender.org/api/current/bpy.ops.object.html#bpy.ops.object.volume_import |
Yes, it happens at bpy.ops.object.volume_import() |
Thanks for clarifications. This feels like a bug in volume_import(), but I'll try to check this out better later on.. |
Ok yes, I think I see. Apparently deleting volume object triggers depsgraph update (and not the volume_import()), thereby the forever loop.. Related to use of Blender application handlers |
- Added a guard variable volume_import_is_running to detect a special case in VTK to Blender Volume node, where deletion of old volume object triggers a depsgraph update in the middle of the update process. This caused infinite loop in frame change when Update All Automatically Update Mode was applied. - Added also a guard variable on_depsgraph_update_is_running, although currently it seems not necessary. Consider it as a kind of extra safety feature for now. The Blender update handlers seem to be called often, and sometimes in quite surprising cases.
Hey I committed something that should fix this issue, could you please test on your end? Thanks! |
Occurs with both Blender versions 3.6 LTS and 4.2 LTS.
Steps to reproduce:
According to my testing, it only happens with VTK To Blender Volume and Update All Automatically selected.
It does not happen with other nodes like VTK To Blender Mesh and VTK To OpenVDB Exporter, or with other Update Modes.
The text was updated successfully, but these errors were encountered: