fix(application): update app spec set status upgrading (#1781)

Co-authored-by: xdonggao <xdonggao@tencent.com>
tkestack · Mar 1, 2022 · f1e7e70 · f1e7e70
1 parent 1cdf116
commit f1e7e70
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/pkg/application/registry/application/storage/rest.go b/pkg/application/registry/application/storage/rest.go
@@ -21,6 +21,7 @@ package storage
 import (
 	"context"
 	"fmt"
+	"reflect"
 
 	"helm.sh/helm/v3/pkg/release"
 	"k8s.io/apimachinery/pkg/api/errors"
@@ -232,11 +233,9 @@ func (rs *REST) Update(ctx context.Context, name string, objInfo rest.UpdatedObj
 		}
 	}
 
-	// if app.Status.RollbackRevision > 0 {
-	// app.Status.Phase = applicationapi.AppPhaseRollingBack
-	// } else {
-	app.Status.Phase = applicationapi.AppPhaseUpgrading
-	// }
+	if !reflect.DeepEqual(oldApp.Spec, app.Spec) {
+		app.Status.Phase = applicationapi.AppPhaseUpgrading
+	}
 
 	return rs.application.Update(ctx, name, rest.DefaultUpdatedObjectInfo(app), createValidation, updateValidation, forceAllowCreate, options)
 }