Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(installer): generate auth, platform, gateway chart custom values #1772

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

wl-chen
Copy link
Collaborator

@wl-chen wl-chen commented Feb 22, 2022

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind feature

What this PR does / why we need it:
generate auth, platform, gateway chart custom values

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@wl-chen wl-chen requested a review from choujimmy as a code owner February 22, 2022 09:08
@wl-chen wl-chen force-pushed the custom-chart-values branch 3 times, most recently from 2ed55bb to b5a5860 Compare February 22, 2022 10:33

type AuthChartValue struct {
TkeAuth *AuthCustomConfig `yaml:"inline"`
Etcd struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create an etcd struct and reuse this struct.

}

type PlatformCustomConfig struct {
API struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seperate these structs.

@wl-chen wl-chen force-pushed the custom-chart-values branch 2 times, most recently from 44b21e1 to 91ecd3c Compare February 23, 2022 07:06
@wl-chen wl-chen force-pushed the custom-chart-values branch from 91ecd3c to ec7eeba Compare February 23, 2022 07:14
@leoryu leoryu merged commit 9258bbe into tkestack:master Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants