cleanup: refactor to use stagex #96
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrvick
force-pushed
the
lance/stagex-refactor
branch
from
18ba573
to
e78b093
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
lrvick
force-pushed
the
lance/stagex-refactor
branch
from
e78b093
to
4249e72
Compare
We also would need to build two separate containers for these, and have multi-architecture logic. Turnkey has no use for arm64 builds and as far as I know no one external uses them either, so I am inclined to not take on that complexity in this PR, though would be happy to review a PR that adds alternative architectures back in a follow-up if there is a use for them. |
lrvick
force-pushed
the
lance/stagex-refactor
branch
from
4249e72
to
37bdd0f
Compare
lrvick
dismissed
james-callahan’s stale review
should be resolved for the scope of this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.